Skip to content

refactor(pubsub): update proto library dependency for linter#3793

Merged
hongalex merged 2 commits intogoogleapis:masterfrom
hongalex:pubsub-fix-lint
Mar 11, 2021
Merged

refactor(pubsub): update proto library dependency for linter#3793
hongalex merged 2 commits intogoogleapis:masterfrom
hongalex:pubsub-fix-lint

Conversation

@hongalex
Copy link
Copy Markdown
Member

This PR fixes some warnings that go-staticcheck was complaining due to the old github.com/golang/protobuf package being superseded by google.golang.org/protobuf. Upgrading to the newer proto packages was an entirely 1 to 1 upgrade with no change in semantics. This PR does not upgrade all references to the old package as autogenerated code still uses github.com/golang/protobuf.

@hongalex hongalex requested review from a team March 10, 2021 22:04
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 10, 2021
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the Pub/Sub API. label Mar 10, 2021
Copy link
Copy Markdown
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a leftover from #1815. LGTM overall.

@hongalex hongalex merged commit f321666 into googleapis:master Mar 11, 2021
@hongalex hongalex deleted the pubsub-fix-lint branch December 10, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants