test(storage): unflake TestIntegration_CancelWrite#3691
Merged
tritone merged 1 commit intogoogleapis:masterfrom Feb 9, 2021
Merged
test(storage): unflake TestIntegration_CancelWrite#3691tritone merged 1 commit intogoogleapis:masterfrom
tritone merged 1 commit intogoogleapis:masterfrom
Conversation
Rarely a wrapped context.Cancel error can be returned from the writer, so the current check will fail. We have to resort to string matching for now, but for Go >= 1.13 errors.Is should work. Fixes googleapis#3688
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: storage
frankyn
approved these changes
Feb 9, 2021
tritone
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rarely a wrapped context.Cancel error can be returned from the
writer, so the current check will fail. We have to resort to string
matching for now, but for Go >= 1.13 errors.Is should work.
Fixes #3688