storage: fix scheme lost when use endpoint - #3509

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

Hi, Is there any chance for this PR merged?

Test Case Failed in

WantRawBasePath is https://xxx but WantScheme is http, is this test case wrong? or did I miss something?

Test Case Failed in https://github.com/googleapis/google-cloud-go/blob/master/storage/storage_test.go#L1285-L1287.

WantRawBasePath is https://xxx but WantScheme is http, is this test case wrong? or did I miss something?

@ddelgrosso1 could you help me with this?

Hi @3pointer, thank you for filing this PR and raising this issue. We are currently looking at related issues and investigating why this is failing. I will update once we know more.

Hi @3pointer, I created a PR against your branch to fix the failing test. If you agree with those changes, please merge and then we can merge this in.

Similar changes were merged in. Thanks for your contribution! Please open an issue or reopen this request if you are still having issues.

Similar changes were merged in. Thanks for your contribution! Please open an issue or reopen this request if you are still having issues.

OK, let me try.