Skip to content

all: remove dependency on honnef.co/go/tools#2496

Merged
codyoss merged 2 commits intogoogleapis:masterfrom
codyoss:staticcheck
Jun 23, 2020
Merged

all: remove dependency on honnef.co/go/tools#2496
codyoss merged 2 commits intogoogleapis:masterfrom
codyoss:staticcheck

Conversation

@codyoss
Copy link
Copy Markdown
Member

@codyoss codyoss commented Jun 19, 2020

I have moved this dependency directly into the container used by
our kokoro jobs so we don't force it on the dependents.

Updates internal bug: b/155334826

I have moved this dependency directly into the container used by
our kokoro jobs so we don't force it on the dependents.

Updates internal bug: b/155334826
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 19, 2020
@codyoss
Copy link
Copy Markdown
Member Author

codyoss commented Jun 19, 2020

After this change is released we can bump the dependency of cloud.google.com/go in all of the sub-modules and run go mod tidy to fully get rid of this.

@codyoss codyoss marked this pull request as ready for review June 23, 2020 16:19
@codyoss codyoss requested review from broady and tbpg as code owners June 23, 2020 16:19
@codyoss codyoss merged commit ad4f932 into googleapis:master Jun 23, 2020
@codyoss codyoss deleted the staticcheck branch June 23, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants