feat(pubsublite): add GMK Implementation changes#14466
Merged
Merged
Conversation
product-auto-label
Bot
added
the
api: pubsublite
brownsuga918
force-pushed
the
pubsublite-changes
branch
from
d040e21 to
0e43217
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for Google Managed Kafka (GMK) as an alternative backend for Pub/Sub Lite, adding a new KafkaPublisher implementation and associated utilities. A critical issue was identified where a package name mismatch in internal/wire/publisher.go will cause compilation errors. Additional feedback suggests refining error handling to prevent client termination on message transformation failures, preserving nanosecond precision for event times, and adhering to best practices by avoiding http.DefaultClient and optimizing Kafka producer throughput.
brownsuga918
force-pushed
the
pubsublite-changes
branch
4 times, most recently
from
f5a6900 to
9226c2d
Compare
johnjcasey
suggested changes
May 5, 2026
johnjcasey
approved these changes
May 22, 2026
pradn
approved these changes
Jun 2, 2026
Ensure Sarama producer and consumer configurations are correctly set up for Google Managed Kafka before constructing clients. Addresses feedback from @johnjcasey regarding Sarama producer validation.
Refactor KafkaPublisher locking to address feedback from @johnjcasey regarding excessive mutex usage. - Convert status to atomic.Int32, eliminating mutex from Start, Stop, and Publish. - Add inFlight WaitGroup to guard against a race where Stop could close the Sarama producer while a Publish send was in progress. - Retain errMu strictly for guarding the error field.
Add explicit documentation and runtime logging warnings to KafkaAdminClient.IncreasePartitions to clarify that Kafka does not automatically rebalance existing data when partition counts grow, and that per-key ordering guarantees may be broken as key hashing adapts to the new partition layout.
Update MigrateOffsets documentation to inline the 5-step offset migration algorithm rather than referencing an external design document, ensuring long-term readability and self-contained package documentation.
Fix doc comment indentation in kafka_migration.go to satisfy goimports.
brownsuga918
force-pushed
the
pubsublite-changes
branch
from
00497b1 to
f081b1b
Compare
This was referenced Jun 16, 2026
Closed
hongalex
pushed a commit
that referenced
this pull request
Jul 6, 2026
🤖 I have created a release *beep* *boop* --- ## [1.9.0](pubsublite/v1.8.2...pubsublite/v1.9.0) (2026-07-06) ### Features * Enable open telemetry attrs ([#14426](#14426)) ([74eab64](74eab64)) * **pubsublite:** Add GMK Implementation changes ([#14466](#14466)) ([50a5550](50a5550)) ### Bug Fixes * **pubsublite:** Reduce pscompat BufferedByteLimit ([#14234](#14234)) ([e768524](e768524)), closes [#14237](#14237) ### Reverts * Release pubsublite 2.0.0 ([#19998](#19998)) ([#20006](#20006)) ([d7b7078](d7b7078)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.