Skip to content

fix(pubsublite): reduce pscompat BufferedByteLimit#14234

Merged
hongalex merged 1 commit into
googleapis:mainfrom
hongalex:fix-pubsublite-32bit
Apr 2, 2026
Merged

fix(pubsublite): reduce pscompat BufferedByteLimit#14234
hongalex merged 1 commit into
googleapis:mainfrom
hongalex:fix-pubsublite-32bit

Conversation

@hongalex

@hongalex hongalex commented Mar 23, 2026

Copy link
Copy Markdown
Member

Reduced default BufferedByteLimit in pscompat layer to ensure compatibility with 32-bit architectures. This prevents compilation errors and potential OOM issues on memory-constrained systems (10 GB default is too high).

Users requiring extremely large buffers on 64-bit systems can still override these settings manually.

Note: Pub/Sub Lite has been deprecated and is scheduled to be shut down in June 2026.

Fixes #14237

@hongalex hongalex requested review from a team as code owners March 23, 2026 18:22
@product-auto-label product-auto-label Bot added the api: pubsublite Issues related to the Pub/Sub Lite API. label Mar 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several byte limits, specifically BufferedByteLimit and MaxOutstandingBytes, from 1e10 to 1e9 in both test settings and the default publish settings. The review highlights that the MaxOutstandingBytes default in pscompat receive settings still needs to be updated to prevent a 32-bit incompatibility issue for subscribers.

Comment thread pubsublite/internal/wire/settings_test.go

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several byte limits in Pub/Sub Lite settings and their corresponding tests, specifically reducing BufferedByteLimit and MaxOutstandingBytes from 10 GB to 1 GB. The review suggests updating the documentation for PublishSettings.BufferedByteLimit to reflect the new 1 GB default and to ensure the correct unit (GB) is used.

Comment thread pubsublite/pscompat/settings.go
@hongalex hongalex merged commit e768524 into googleapis:main Apr 2, 2026
10 checks passed
@hongalex hongalex deleted the fix-pubsublite-32bit branch April 2, 2026 23:39
hongalex pushed a commit that referenced this pull request Jul 6, 2026
🤖 I have created a release *beep* *boop*
---


##
[1.9.0](pubsublite/v1.8.2...pubsublite/v1.9.0)
(2026-07-06)


### Features

* Enable open telemetry attrs
([#14426](#14426))
([74eab64](74eab64))
* **pubsublite:** Add GMK Implementation changes
([#14466](#14466))
([50a5550](50a5550))


### Bug Fixes

* **pubsublite:** Reduce pscompat BufferedByteLimit
([#14234](#14234))
([e768524](e768524)),
closes
[#14237](#14237)


### Reverts

* Release pubsublite 2.0.0
([#19998](#19998))
([#20006](#20006))
([d7b7078](d7b7078))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the Pub/Sub Lite API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pubsublite: use of 10GB int consts breaks 32 bit systems

2 participants