feat(bigtable): add handling of longupdown metrics aka gauge#13871
feat(bigtable): add handling of longupdown metrics aka gauge#13871sushanb merged 1 commit intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
the
api: bigtable
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively adds support for gauge metrics (represented as non-monotonic sums) in the monitoring exporter. The changes correctly identify these metrics and adjust their time intervals by setting the start time equal to the end time, which aligns with the requirements of the Cloud Monitoring API for GAUGE metric kinds. The refactoring of toNonemptyTimeIntervalpb to toTimeIntervalPb is a welcome improvement for clarity, and it also includes a beneficial fix for calculating cumulative metric intervals. The accompanying test changes, including a new test for gauge intervals, are thorough and ensure the new logic is well-covered. Overall, this is a solid contribution that enhances the metrics exporting capabilities.
2 participants
Same as googleapis/java-bigtable#2719 for subchannel/open_connections