feat(bigtable): add preemptive connection recycler#13860
Merged
sushanb merged 6 commits intogoogleapis:mainfrom Feb 19, 2026
Merged
feat(bigtable): add preemptive connection recycler#13860sushanb merged 6 commits intogoogleapis:mainfrom
sushanb merged 6 commits intogoogleapis:mainfrom
Conversation
product-auto-label
Bot
added
the
api: bigtable
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a preemptive connection recycler to manage the lifecycle of connections in the Bigtable client's connection pool, including configuration, background logic, and client integration. However, a security vulnerability was identified: the random number generator used for connection recycling jitter is seeded with a predictable value, which could lead to synchronized connection recycling at scale and impact service availability. It is recommended to use a cryptographically secure random source for seeding. Additionally, there are suggestions to improve code clarity, conventions, and configuration handling, such as addressing a non-idiomatic package name, a silent override of user configuration, and minor typos.
mutianf
reviewed
Feb 19, 2026
| EnableDynamicChannelPool bool | ||
| // DisableDynamicChannelPool disables the dynamic channel resizing based on load | ||
| // Dynamic channel resizing is enabled by default to resize based on load and avoid queuing of requests. | ||
| DisableDynamicChannelPool bool |
Contributor
There was a problem hiding this comment.
This makes the code a little hard to read. Is it possible to have a constructor function that returns true for these variables by default?
mutianf
approved these changes
Feb 19, 2026
bhshkh
added a commit
that referenced
this pull request
Mar 16, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.8.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:19bb93e8f1f916c61b597db2bad65dc432f79baaabb210499d7d0e4ad1dffe29 <details><summary>bigtable: 1.43.0</summary> ## [1.43.0](bigtable/v1.42.0...bigtable/v1.43.0) (2026-03-16) ### Features * Add support for creating Instance with tags (#13459) ([1bce843](1bce843e)) * support tiered storage (#13793) ([39a25b9](39a25b92)) * add handling of longupdown metrics aka gauge (#13871) ([519ed9b](519ed9b0)) * Use direct access when supported. Guarded by enabling… (#13873) ([5ea1f5f](5ea1f5f9)) * add preemptive connection recycler (#13860) ([6b69ee3](6b69ee38)) * make downscalling less aggressive (#14123) ([7ac72cc](7ac72cc8)) * add pacemaker in connpool (#13862) ([9af047f](9af047f7)) * populate ip protocol for direct access checker and rename a method to be concise (#14011) ([9c5e655](9c5e6551)) * add connection factory to abstract connection (#13755) ([b08ea15](b08ea15f)) * make pow of 2 default lb policy (#14131) ([b5f7bf2](b5f7bf27)) * derive conn pool from resolver (#14147) ([b903e29](b903e299)) * add load balancing penalty for channel (#14149) ([bb64998](bb649988)) * cap increase in conn for dynamic chan pool (#14144) ([e0701a4](e0701a46)) * switch to rand v2 (#14008) ([ee6f425](ee6f4251)) ### Bug Fixes * slighly change instruction for direct access (#14119) ([7dd4948](7dd4948d)) * refactor bigtable.go into separate file path per interfaces (#13818) ([c8ae2e2](c8ae2e2a)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.