Skip to content

fix(bigtable): refactor bigtable.go into separate files per interfaces#13818

Merged
sushanb merged 4 commits intogoogleapis:mainfrom
sushanb:refactor_bigtable
Feb 12, 2026
Merged

fix(bigtable): refactor bigtable.go into separate files per interfaces#13818
sushanb merged 4 commits intogoogleapis:mainfrom
sushanb:refactor_bigtable

Conversation

@sushanb
Copy link
Copy Markdown
Contributor

@sushanb sushanb commented Feb 9, 2026

No description provided.

@sushanb sushanb requested review from a team, bhshkh and nimf February 9, 2026 21:23
@sushanb sushanb requested review from a team as code owners February 9, 2026 21:23
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Feb 9, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Feb 9, 2026

Summary of Changes

Hello @sushanb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the codebase's structure by breaking down a large, single file into multiple, purpose-specific files. This change aims to make the Bigtable client library easier to navigate, understand, and maintain, by logically grouping related functions and types.

Highlights

  • Code Organization: The monolithic bigtable.go file has been refactored into several smaller, more focused files, improving modularity and maintainability.
  • Interface-Specific Files: Key functionalities such as ApplyBulk, ReadModifyWrite, SampleRowKeys, and query-related operations are now housed in their own dedicated Go files.
  • Client and Table Structs: The core Client and Table struct definitions, along with their associated methods, have been moved to client.go and table.go respectively, centralizing their logic.
Changelog
  • bigtable/apply_bulk.go
    • Added new file to encapsulate the ApplyBulk method and its supporting functions, including error handling and entry grouping logic.
  • bigtable/bigtable.go
    • Removed numerous client, table, query, and mutation-related definitions and methods, significantly reducing its size and scope.
    • Updated imports to reflect the new file structure.
  • bigtable/client.go
    • Added new file to define the Client struct, its configuration (ClientConfig), and methods for client creation, closing, and resource name formatting.
    • Includes methods for opening tables, authorized views, materialized views, and performing PingAndWarm operations.
  • bigtable/query.go
    • Added new file to house all query-related logic, including PreparedStatement, BoundStatement, and their associated methods for preparing and executing queries.
  • bigtable/read_modify_write.go
    • Added new file to contain the ApplyReadModifyWrite method and the ReadModifyWrite struct, along with its operations like AppendValue and Increment.
  • bigtable/sample_row_keys.go
    • Added new file to define the SampleRowKeys method and its internal implementation.
  • bigtable/table.go
    • Added new file to define the TableAPI interface, tableImpl struct, and the Table struct, centralizing table-specific operations and their metrics tracing.
Activity
  • sushanb created this pull request to refactor the Bigtable client library.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a well-executed refactoring that splits the large bigtable.go file into smaller, more manageable files based on functionality. This significantly improves the code's organization and maintainability. The changes primarily involve moving code without altering the underlying logic. The refactoring appears to be solid. I have one minor suggestion regarding a missing file header for consistency.

Comment thread bigtable/apply_bulk.go Outdated
nimf
nimf approved these changes Feb 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@nimf nimf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sushanb sushanb merged commit c8ae2e2 into googleapis:main Feb 12, 2026
12 checks passed
@sushanb sushanb deleted the refactor_bigtable branch February 12, 2026 02:36
@anowardear062-svg
Copy link
Copy Markdown

anowardear062-svg commented Feb 12, 2026

Support and proses

@bhshkh bhshkh mentioned this pull request Mar 16, 2026
Merged
bhshkh added a commit that referenced this pull request Mar 16, 2026
@bhshkh
chore: librarian release pull request: 20260316T221702Z (#14185)
97af151 
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.8.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:19bb93e8f1f916c61b597db2bad65dc432f79baaabb210499d7d0e4ad1dffe29
<details><summary>bigtable: 1.43.0</summary>

##
[1.43.0](bigtable/v1.42.0...bigtable/v1.43.0)
(2026-03-16)

### Features

* Add support for creating Instance with tags (#13459)
([1bce843](1bce843e))

* support tiered storage (#13793)
([39a25b9](39a25b92))

* add handling of longupdown metrics aka gauge (#13871)
([519ed9b](519ed9b0))

* Use direct access when supported. Guarded by enabling… (#13873)
([5ea1f5f](5ea1f5f9))

* add preemptive connection recycler (#13860)
([6b69ee3](6b69ee38))

* make downscalling less aggressive (#14123)
([7ac72cc](7ac72cc8))

* add pacemaker in connpool (#13862)
([9af047f](9af047f7))

* populate ip protocol for direct access checker and rename a method to
be concise (#14011)
([9c5e655](9c5e6551))

* add connection factory to abstract connection (#13755)
([b08ea15](b08ea15f))

* make pow of 2 default lb policy (#14131)
([b5f7bf2](b5f7bf27))

* derive conn pool from resolver (#14147)
([b903e29](b903e299))

* add load balancing penalty for channel (#14149)
([bb64998](bb649988))

* cap increase in conn for dynamic chan pool (#14144)
([e0701a4](e0701a46))

* switch to rand v2 (#14008)
([ee6f425](ee6f4251))

### Bug Fixes

* slighly change instruction for direct access (#14119)
([7dd4948](7dd4948d))

* refactor bigtable.go into separate file path per interfaces (#13818)
([c8ae2e2](c8ae2e2a))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nimf nimf nimf approved these changes

@bhshkh bhshkh Awaiting requested review from bhshkh

+2 more reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@anowardear062-svg anowardear062-svg anowardear062-svg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sushanb @anowardear062-svg @nimf