fix: don't update global object's readhandle in MRD#13575
fix: don't update global object's readhandle in MRD#13575cpriti-os merged 1 commit intogoogleapis:mainfrom
Conversation
Summary of ChangesHello @krishnamd-jkp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where a global object's read handle was being incorrectly updated during multi-range download sessions. By preventing this global update, the change resolves a class of missing metadata errors that could arise in subsequent download operations for the same object, ensuring data consistency and reliable access. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a bug where a global object's read handle was being updated during a multi-range download, which could lead to metadata errors on subsequent downloads. The change correctly removes the code that was updating this handle, leaving only the update to the downloader's internal lastReadHandle. The fix is targeted and aligns with the stated goal in the pull request description. The change looks good and I have no further comments.
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:718167d5c23ed389b41f617b3a00ac839bdd938a6bd2d48ae0c2f1fa51ab1c3d <details><summary>storage: 1.59.1</summary> ## [1.59.1](storage/v1.59.0...storage/v1.59.1) (2026-01-14) ### Bug Fixes * remove mandatory attrs response in MRD (#13585) ([6752a49](6752a496)) * close attrsReady channel when metadata is missing (#13574) ([712f562](712f5627)) * don't update global object's readhandle in MRD (#13575) ([bc92500](bc925001)) </details>
2 participants
This change will make sure global object's read handle is not updated. This will avoid missing metadata errors in new MRDs for the same object.