feat(bigquery): transition format options#13422
Conversation
This PR is minimal, and updates all callsites that use the older UseInt64Timestamp boolean for controlling output to instead use the newer TimestampOutputFormat option and specify it using INT64. Followup PRs will update this to use the new ISO string for output.
Summary of ChangesHello @shollyman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the BigQuery client library by transitioning its timestamp output formatting mechanism. It replaces the older boolean flag Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly transitions from the deprecated UseInt64Timestamp boolean to the TimestampOutputFormat option for BigQuery calls, setting it to "INT64". The changes are applied consistently across all relevant call sites and tests. My main feedback is to define the string "INT64" as a constant to avoid magic strings and improve maintainability. This is particularly relevant as a follow-up PR is planned to change this value, and using a constant would make that change safer and more explicit. I've left comments on each occurrence.
This PR is minimal, and updates all callsites that use the older UseInt64Timestamp boolean for controlling output to instead use the newer TimestampOutputFormat option and specify it using INT64. Followup PRs will update this to use the new ISO string for output. Towards internal b/447623020
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.8.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:01189c9771ac4150742aed38eb52e19a008018889066002742034b7f82db070f <details><summary>bigquery: 1.73.0</summary> ## [1.73.0](bigquery/v1.72.0...bigquery/v1.73.0) (2026-02-04) ### Features * add Stored Procedure Sharing support for analyticshub listings (PiperOrigin-RevId: 827828462) ([185951b](185951b3)) * add tags support for Pub/Sub subscriptions (PiperOrigin-RevId: 827828462) ([185951b](185951b3)) * Support picosecond timestamp precision in BigQuery Storage API (PiperOrigin-RevId: 829486853) ([185951b](185951b3)) * add timestamp precision support to schema (#13421) ([52020af](52020af5)) * transition format options (#13422) ([59efe32](59efe323)) ### Bug Fixes * make additional errors retriable: tcp timeout and http2 client connection lost (#13269) ([466d309](466d309d)) * roundtrip readonly fields (#13370) ([9e84705](9e847052)) ### Documentation * change comment indicating `enable_gemini_in_bigquery` field for BigQuery Reservation Assignments is deprecated (PiperOrigin-RevId: 850121797) ([35d7578](35d75787)) </details>
This PR is minimal, and updates all callsites that use the older UseInt64Timestamp boolean for controlling output to instead use the newer TimestampOutputFormat option and specify it using INT64.
Followup PRs will update this to use the new ISO string for output.
Towards internal b/447623020