feat(bigtable): precompute featureflags in client and reuse#13297
feat(bigtable): precompute featureflags in client and reuse#13297sushanb merged 3 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
the
api: bigtable
Summary of ChangesHello @sushanb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces an optimization to the Bigtable client by changing how feature flags metadata is handled. Instead of generating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a good performance optimization by pre-computing and caching the feature flags metadata upon client initialization. This avoids redundant computations on every API call. The implementation is solid: a new field stores the pre-computed metadata, it's initialized correctly in NewClientWithConfig, and all call sites are updated to use the cached value. The refactoring of the feature flag creation logic into a standalone function is also a clean change. I have a couple of minor suggestions to improve comment clarity for better long-term maintainability.
bhshkh
left a comment
bhshkh
left a comment
There was a problem hiding this comment.
please fix gemini suggested comments
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:718167d5c23ed389b41f617b3a00ac839bdd938a6bd2d48ae0c2f1fa51ab1c3d <details><summary>bigtable: 1.41.0</summary> ## [1.41.0](bigtable/v1.40.1...bigtable/v1.41.0) (2025-12-15) ### Features * add PeerInfo proto in Bigtable API (PiperOrigin-RevId: 829585900) ([185951b](185951b3)) * precompute featureflags in client and reuse (#13297) ([3b3253a](3b3253ac)) * Add experimental Bigtable connection pool with custom load balancing strategy. (#12882) ([7aa9612](7aa96127)) * Enable ALTS hard bound token in Bigtable w/ direct access (#13153) ([9023934](90239341)) * Enable routing cookie and attempt headers for enhanced retries (#12964) ([96cfd47](96cfd47a)) ### Bug Fixes * fix project id sent in otel (#13286) ([4865868](4865868c)) * screaming uppercase metric status (#13484) ([b35ee8f](b35ee8fd)) ### Performance Improvements * parallelize the exportTimeSeries function (#13004) ([bafd691](bafd691d)) </details>
2 participants
No description provided.