Skip to content

feat(auth): adds support for X509 workload identity federation#10373

Merged
aeitzman merged 18 commits intogoogleapis:mainfrom
aeitzman:external-account-mtls
Aug 7, 2024
Merged

feat(auth): adds support for X509 workload identity federation#10373
aeitzman merged 18 commits intogoogleapis:mainfrom
aeitzman:external-account-mtls

Conversation

@aeitzman
Copy link
Copy Markdown
Contributor

No description provided.

@aeitzman aeitzman added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 12, 2024
@aeitzman aeitzman requested a review from a team June 12, 2024 16:45
@codyoss
Copy link
Copy Markdown
Member

codyoss commented Jun 12, 2024

cc @andyrzhao

Comment thread auth/credentials/internal/externalaccount/externalaccount.go Outdated
Comment thread auth/credentials/internal/externalaccount/x509_provider.go
…isibility into whether the client should be overriden
@codyoss codyoss changed the title feat: adds support for X509 workload identity federation feat(auth): adds support for X509 workload identity federation Jun 24, 2024
@codyoss
Copy link
Copy Markdown
Member

codyoss commented Jun 24, 2024

@andyrzhao Would you mind looking at this too since you are active in this space.

Comment thread auth/credentials/internal/externalaccount/url_provider.go
Copy link
Copy Markdown
Contributor

@andyrzhao andyrzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread auth/internal/credsfile/filetype.go Outdated
@aeitzman aeitzman removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants