fix(internal/postprocessor): use approved image tag #10341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahdietz
added
the
automerge
quartzmo
approved these changes
Jun 6, 2024
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
🤖 I have created a release *beep* *boop* --- ## [0.115.0](https://togithub.com/googleapis/google-cloud-go/compare/v0.114.0...v0.115.0) (2024-06-12) ### Features * **internal/trace:** Deprecate OpenCensus support ([#10287](https://togithub.com/googleapis/google-cloud-go/issues/10287)) ([430ce8a](https://togithub.com/googleapis/google-cloud-go/commit/430ce8adea2d0be43461e2ca783b7c17794e983f)), refs [#2205](https://togithub.com/googleapis/google-cloud-go/issues/2205) [#8655](https://togithub.com/googleapis/google-cloud-go/issues/8655) ### Bug Fixes * **internal/postprocessor:** Use approved image tag ([#10341](https://togithub.com/googleapis/google-cloud-go/issues/10341)) ([a388fe5](https://togithub.com/googleapis/google-cloud-go/commit/a388fe5cf075d0af986861c70dcb7b9f97c31019)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the tag used for postprocessor image to approved prefix. Add one with
latestsuffix on approved prefix, and another using the commit sha that produced the image - this way when the next image is pushed withlatestthe dangling image(s) will still be tagged with the approved tag prefix.Update instructions accordingly. Note: the
docker inspectandsedcommands weren't working for me on gLinux, so I removed them and replaced them with the slightly simpler, but not automated, steps of copying it from thepulloutput.internal bug http://b/334181347