feat(logging): OpenTelemetry trace/span ID integration for Go logging library#10030
Conversation
product-auto-label
Bot
added
the
api: logging
| } | ||
| } | ||
|
|
||
| func TestToLogEntryOTelIntegration(t *testing.T) { |
There was a problem hiding this comment.
Do we plan to add system tests to start otel span and compare auto-generated otel spanId with the injected logEntry spanId?
There was a problem hiding this comment.
@cindy-peng I just added an integration/system test for the exact same test case, just with different span setups.
gkevinzheng
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
| ctx := context.Background() | ||
|
|
||
| // Set up an OTel SDK tracer if integration test, mock noop tracer if not. | ||
| if integrationTest { |
There was a problem hiding this comment.
Do we have a dedicated place for integration tests in Go Logging library?
For example, for Java-logging and Node-logging, there is a separate folder for integration tests:
https://github.com/googleapis/java-logging/tree/main/google-cloud-logging/src/test/java/com/google/cloud/logging/it
https://github.com/googleapis/nodejs-logging/tree/main/system-test
There was a problem hiding this comment.
I don't think we have any right now, but if enough system tests happen that are kinda different from integration tests controlled by the integrationTest flag I could make a separate file for them.
6 participants
Fixes #9302