fix(internal/gapicgen): skip empty file paths in gatherChanges (#13198)

quartzmo · web-flow · commit 60ba77eccddf · 2025-10-21T11:30:48.000-04:00
refs: #13188 refs: #13189
diff --git a/internal/gapicgen/generator/generator.go b/internal/gapicgen/generator/generator.go
@@ -52,7 +52,7 @@ func Generate(ctx context.Context, conf *Config) ([]*git.ChangeInfo, error) {
 		var err error
 		changes, err = gatherChanges(conf.GoogleapisDir, conf.GenprotoDir)
 		if err != nil {
-			return nil, fmt.Errorf("error gathering commit info")
+			return nil, fmt.Errorf("error gathering commit info: %w", err)
 		}
 		if err := recordGoogleapisHash(conf.GoogleapisDir, conf.GenprotoDir); err != nil {
 			return nil, err
@@ -80,6 +80,9 @@ func gatherChanges(googleapisDir, genprotoDir string) ([]*git.ChangeInfo, error)
 		}
 		protos := make(map[string]struct{})
 		for _, file := range files {
+			if file == "" {
+				continue
+			}
 			if !strings.HasSuffix(file, ".proto") {
 				continue
 			}

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ func Generate(ctx context.Context, conf Config) ([]git.ChangeInfo, error) {`
`52`	`52`	`var err error`
`53`	`53`	`changes, err = gatherChanges(conf.GoogleapisDir, conf.GenprotoDir)`
`54`	`54`	`if err != nil {`
`55`		`- return nil, fmt.Errorf("error gathering commit info")`
	`55`	`+ return nil, fmt.Errorf("error gathering commit info: %w", err)`
`56`	`56`	`}`
`57`	`57`	`if err := recordGoogleapisHash(conf.GoogleapisDir, conf.GenprotoDir); err != nil {`
`58`	`58`	`return nil, err`
`@@ -80,6 +80,9 @@ func gatherChanges(googleapisDir, genprotoDir string) ([]*git.ChangeInfo, error)`
`80`	`80`	`}`
`81`	`81`	`protos := make(map[string]struct{})`
`82`	`82`	`for _, file := range files {`
	`83`	`+ if file == "" {`
	`84`	`+ continue`
	`85`	`+ }`
`83`	`86`	`if !strings.HasSuffix(file, ".proto") {`
`84`	`87`	`continue`
`85`	`88`	`}`