fix(pubsub/pstest): align fake handling of bqconfig subscription to server behavior (#8066)

hongalex · web-flow · commit 57914ec4d5d2 · 2023-06-08T10:00:50.000-07:00
diff --git a/pubsub/pstest/fake.go b/pubsub/pstest/fake.go
@@ -499,9 +499,10 @@ func (s *GServer) CreateSubscription(_ context.Context, ps *pb.Subscription) (*p
 	if ps.PushConfig == nil {
 		ps.PushConfig = &pb.PushConfig{}
 	}
-	if ps.BigqueryConfig == nil {
-		ps.BigqueryConfig = &pb.BigQueryConfig{}
-	} else if ps.BigqueryConfig.Table != "" {
+	// Consider any table set to mean the config is active.
+	// We don't convert nil config to empty like with PushConfig above
+	// as this mimics the live service behavior.
+	if ps.GetBigqueryConfig() != nil && ps.GetBigqueryConfig().GetTable() != "" {
 		ps.BigqueryConfig.State = pb.BigQueryConfig_ACTIVE
 	}
 	ps.TopicMessageRetentionDuration = top.proto.MessageRetentionDuration
@@ -605,7 +606,7 @@ func (s *GServer) UpdateSubscription(_ context.Context, req *pb.UpdateSubscripti
 			sub.proto.PushConfig = req.Subscription.PushConfig
 
 		case "bigquery_config":
-			// If bq config is nil here, it will have been cleared.
+			// If bq config is nil here, it will be cleared.
 			// Otherwise, we'll consider the subscription active if any table is set.
 			sub.proto.BigqueryConfig = req.GetSubscription().GetBigqueryConfig()
 			if sub.proto.GetBigqueryConfig() != nil {
diff --git a/pubsub/pstest/fake_test.go b/pubsub/pstest/fake_test.go
@@ -1583,8 +1583,8 @@ func TestSubscriptionPushPull(t *testing.T) {
 	if diff := testutil.Diff(got.PushConfig, new(pb.PushConfig)); diff != "" {
 		t.Errorf("sub.PushConfig should be zero value\n%s", diff)
 	}
-	if diff := testutil.Diff(got.BigqueryConfig, new(pb.BigQueryConfig)); diff != "" {
-		t.Errorf("sub.BigqueryConfig should be zero value\n%s", diff)
+	if got.BigqueryConfig != nil {
+		t.Errorf("sub.BigqueryConfig should be nil, got %s", got.BigqueryConfig)
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1583,8 +1583,8 @@ func TestSubscriptionPushPull(t *testing.T) {`
`1583`	`1583`	`if diff := testutil.Diff(got.PushConfig, new(pb.PushConfig)); diff != "" {`
`1584`	`1584`	`t.Errorf("sub.PushConfig should be zero value\n%s", diff)`
`1585`	`1585`	`}`
`1586`		`- if diff := testutil.Diff(got.BigqueryConfig, new(pb.BigQueryConfig)); diff != "" {`
`1587`		`- t.Errorf("sub.BigqueryConfig should be zero value\n%s", diff)`
	`1586`	`+ if got.BigqueryConfig != nil {`
	`1587`	`+ t.Errorf("sub.BigqueryConfig should be nil, got %s", got.BigqueryConfig)`
`1588`	`1588`	`}`
`1589`	`1589`	`}`
`1590`	`1590`