fix(pubsub): make receipt modack call async (#6335)

hongalex · noahdietz · commit 01596d4a8861 · 2022-07-18T14:26:13.000-07:00
* fix(pubsub): make receipt modack call async

* dont propagate modack errors

* update comment on why errors are not checked
diff --git a/pubsub/iterator.go b/pubsub/iterator.go
@@ -246,11 +246,13 @@ func (it *messageIterator) receive(maxToPull int32) ([]*Message, error) {
 	}
 	deadline := it.ackDeadline()
 	it.mu.Unlock()
-	if len(ackIDs) > 0 {
-		if !it.sendModAck(ackIDs, deadline) {
-			return nil, it.err
+	go func() {
+		if len(ackIDs) > 0 {
+			// Don't check the return value of this since modacks are fire and forget,
+			// meaning errors should not be propagated to the client.
+			it.sendModAck(ackIDs, deadline)
 		}
-	}
+	}()
 	return msgs, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -246,11 +246,13 @@ func (it messageIterator) receive(maxToPull int32) ([]Message, error) {`
`246`	`246`	`}`
`247`	`247`	`deadline := it.ackDeadline()`
`248`	`248`	`it.mu.Unlock()`
`249`		`- if len(ackIDs) > 0 {`
`250`		`- if !it.sendModAck(ackIDs, deadline) {`
`251`		`- return nil, it.err`
	`249`	`+ go func() {`
	`250`	`+ if len(ackIDs) > 0 {`
	`251`	`+ // Don't check the return value of this since modacks are fire and forget,`
	`252`	`+ // meaning errors should not be propagated to the client.`
	`253`	`+ it.sendModAck(ackIDs, deadline)`
`252`	`254`	`}`
`253`		`- }`
	`255`	`+ }()`
`254`	`256`	`return msgs, nil`
`255`	`257`	`}`
`256`	`258`