test(Storage): Changes resources accessed by unauthenticated access tests.#6025
Merged
amanda-tarafa merged 1 commit intogoogleapis:masterfrom Mar 12, 2021
Merged
Conversation
google-cla
Bot
added
the
cla: yes
product-auto-label
Bot
added
the
api: storage
jskeet
approved these changes
Mar 12, 2021
tritone
added a commit
to tritone/google-cloud-go
that referenced
this pull request
Mar 12, 2021
These tests rely on public data in the Landsat bucket (https://cloud.google.com/storage/docs/public-datasets/landsat). The data under PRE/ has been removed, so I shifted these to instead use another prefix which should be stable. Already done for dotnet here: googleapis/google-cloud-dotnet#6025 Fixes googleapis#3800 Fixes googleapis#3801
tritone
added a commit
to googleapis/google-cloud-go
that referenced
this pull request
Mar 12, 2021
These tests rely on public data in the Landsat bucket (https://cloud.google.com/storage/docs/public-datasets/landsat). The data under PRE/ has been removed, so I shifted these to instead use another prefix which should be stable. Already done for dotnet here: googleapis/google-cloud-dotnet#6025 Fixes #3800 Fixes #3801
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The landsat object we were accessing does not exist anymore. This fixes the latest CI failures.
The other test was a leftover from #5548. I've changed it to list the Landsat bucket instead of whatever internal bucket we had, so that we don't have to worry about our internal bucket being public or not.