Recreate the common storage test bucket#5580
Merged
jskeet merged 2 commits intogoogleapis:masterfrom Nov 16, 2020
Merged
Conversation
This bucket is currently called storage-library-test-bucket. It's owned by an integration test project, but with read access for the organization. This means 3rd party users trying to run tests will see failures, but that's probably okay. (Otherwise we need exemptions for public objects.)
google-cla
Bot
added
the
cla: yes
amanda-tarafa
approved these changes
Nov 16, 2020
| var serviceAccount = GoogleCredential.GetApplicationDefault().UnderlyingCredential as ServiceAccountCredential; | ||
| if (serviceAccount is null) | ||
| { | ||
| throw new InvalidOperationException("Default credentials are not for a service account, so we can't determine the project ID"); |
Contributor
There was a problem hiding this comment.
nit: Or take the projectId as an arg.
But really totally fine as is.
Collaborator
Author
There was a problem hiding this comment.
I did wonder about that - it's basically an option if we find it's a problem :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5548.