Remember that we've pushed when the watch state is reconnected#2550
Merged
jskeet merged 1 commit intogoogleapis:masterfrom Oct 2, 2018
Merged
Remember that we've pushed when the watch state is reconnected#2550jskeet merged 1 commit intogoogleapis:masterfrom
jskeet merged 1 commit intogoogleapis:masterfrom
Conversation
Fixes googleapis#2542. All our tests for WatchState are via proto-based conformance tests. There will be a new test for that case over time, but it's not present yet. I didn't feel it worth creating a new test class to do this manually until that point. (I can do so if necessary.) The existing tests all still pass, and I've validated manually that this fixes the problem (both for collection and document listen operations).
googlebot
added
the
cla: yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2542.
All our tests for WatchState are via proto-based conformance tests.
There will be a new test for that case over time, but it's not present yet.
I didn't feel it worth creating a new test class to do this manually until that point. (I can do so if necessary.)
The existing tests all still pass, and I've validated manually that this fixes the problem (both for collection and document listen operations).