feat: All BatchGetDocuments RPCs to have customized retry settiings (per-FirestoreDb)#11561
Merged
jskeet merged 1 commit intogoogleapis:mainfrom Jan 20, 2024
Merged
feat: All BatchGetDocuments RPCs to have customized retry settiings (per-FirestoreDb)#11561jskeet merged 1 commit intogoogleapis:mainfrom
jskeet merged 1 commit intogoogleapis:mainfrom
Conversation
…per-FirestoreDb) fix: Use FirestoreSettings.BatchGetDocuments for batch timing This will change the default timeout from 10 minutes to 5 minutes, but that will bring us in line with other clients. Any customer observing problems after this change can manually set the timeout in FirestoreSettings. I regard this as a "sufficiently safe" (but still *potentially* breaking) change to not merit a new major version. Fixes googleapis#11322.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Use FirestoreSettings.BatchGetDocuments for batch timing
This will change the default timeout from 10 minutes to 5 minutes, but that will bring us in line with other clients. Any customer observing problems after this change can manually set the timeout in FirestoreSettings. I regard this as a "sufficiently safe" (but still potentially breaking) change to not merit a new major version.
Fixes #11322.
(While it would be nice to have per-RPC settings, that's probably too niche a requirement to be worth the API surface upheaval, at least for now.)