feat: update using null-safety generator change#69
feat: update using null-safety generator change#69devoncarew merged 5 commits intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several packages for null-safety, which is a great improvement for code robustness. The changes mostly involve removing unnecessary null-check operators (!) on properties that are now non-nullable, which is correct. However, I've found a few instances in the example code where a risky null assertion (!) has been introduced on a nullable property. This could lead to runtime exceptions and makes the examples less robust. I've left specific comments with suggestions to fix this.
...rated/google_cloud_ai_generativelanguage_v1beta/example/application_default_credentials.dart
Show resolved
Hide resolved
Could you please remove the Or just land this and I'll do that in a follow-up PR. |
Done! |
2 participants
Update the packages here using the null-safety generator change:
Previously as a draft at #58; done as separate commits to make review a little easier.
@brianquinlan, this does not include sidekick / dart package version changes. I assume we'll want to bump everything (to 0.2.0?). Not sure if we're bumping on changes or on publish (or don't have a specific process yet).