feat: add isNotDefault extension methods for core proto types#68
Merged
devoncarew merged 4 commits intogoogleapis:mainfrom Oct 31, 2025
Merged
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Contributor
brianquinlan
left a comment
brianquinlan
left a comment
There was a problem hiding this comment.
I think that you need to add a version to the .sidekick.toml file for this package.
devoncarew
commented
Oct 31, 2025
Contributor
Author
devoncarew
left a comment
devoncarew
left a comment
There was a problem hiding this comment.
I think that you need to add a version to the .sidekick.toml file for this package.
I incremented the protobuf package version from 0.1.0 to 0.1.1 (and updated the dep other packages have on it in the main sidekick file).
brianquinlan
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isNotDefaultextension methods for core proto typesThis is the hand-written portions of #58. I'll follow this up w/ generator changes (in the librarian repo), and then a PR back to this repo that will re-generate the packages and update test and example code (the rest of #58).
Happy to bike-shed on the extension method name(s). It's
isNotDefaultnow, but could be something likenotDefault, ... .cc @natebosch