fix: ConfigurationException in fromApiKey#64
Merged
brianquinlan merged 5 commits intogoogleapis:mainfrom Oct 28, 2025
Merged
Conversation
Change `fromApiKey` to throw `ConfigurationException` rather than `ArgumentError` Depends on googleapis/librarian#2697
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new ConfigurationException to provide more specific error information, which is a good improvement over using the generic ArgumentError. The changes in httpClientFromApiKey for both VM and web platforms are correctly implemented. I have one suggestion to improve the new exception class for better consistency and usability.
natebosch
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
fromApiKeyto throwConfigurationExceptionrather thanArgumentErrorDepends on googleapis/librarian#2697
Fixes #53
Non-generated changes:
**/.sidekick.yamlgoogle_cloud_gax