fix: Remove dependency on dart:io#56
Merged
brianquinlan merged 6 commits intogoogleapis:mainfrom Oct 27, 2025
Merged
Conversation
Paired with googleapis/librarian#2672 Fixes googleapis#55
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully removes the direct dependency on dart:io for web clients by using conditional exports, which is a great improvement for web compatibility. The implementation looks correct. However, I've found a couple of issues with the documentation for the new httpClientFromApiKey function. In the VM implementation, there's a minor typo. More importantly, in the web implementation, the documentation is copied from the VM version and is misleading because it mentions environment variables, which are not supported on the web. I've left specific comments with suggestions to fix these documentation issues.
natebosch
approved these changes
Oct 24, 2025
brianquinlan
added a commit
to googleapis/librarian
that referenced
this pull request
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired with googleapis/librarian#2672
The non-generated changes are to the
.sidekick.tomlfiles and to_gax.Fixes #55