feat: Remove protobuf dep on _gax#52
Merged
brianquinlan merged 4 commits intogoogleapis:mainfrom Oct 23, 2025
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a well-executed refactoring that extracts Protobuf-related base classes from google_cloud_gax into a new, dedicated google_cloud_protobuf package. This significantly improves the project's architecture by promoting better separation of concerns and modularity. The associated tests have been thoughtfully migrated and enhanced with more specific matchers, increasing their robustness. The change is clean and focused. I have one suggestion to clean up some leftover documentation to finalize this refactoring.
natebosch
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved:
JsonEncodable,ProtoMessage,ProtoEnumtogoogle_cloud_protobuf/src/protobuf.p.dartgoogle_cloud_gax/src/encoding.dart(and test [tests were updated]) to google_cloud_protobuf/src/encoding.dart`Added a dependency on
package:google_cloud_protobuftopackage:google_cloud_gaxto acomodate the move ofJsonEncodable.Depends on the code generation in googleapis/librarian#2660