Add cctz as a submodule. #92
Conversation
This is needed by abseil.io, in particular for Mutex. This is step 2 from https://github.com/abseil/abseil-cpp/blob/master/CMake/README.md
googlebot
added
the
cla: yes
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
Is there a particular reason we need to use absl::Mutex? I find the arguments for it uncompelling.
And if cctz is a dependency why is it not included in abseil.io? Do you know? And how are we supposed to keep these two libraries to consistent revisions?
| [submodule "third_party/abseil"] | ||
| path = third_party/abseil | ||
| url = https://github.com/abseil/abseil-cpp.git | ||
| [submodule "third_party/cctz"] |
There was a problem hiding this comment.
Ugh. Why does abseil not install cctz? And how do we make sure we update both at the same time (and to a consistent revision).
There was a problem hiding this comment.
They do, they bring it into their WORKSPACE file, presumably for a Bazel build:
# CCTZ (Time-zone framework). http_archive( name = "com_googlesource_code_cctz", urls = ["https://github.com/google/cctz/archive/master.zip"], strip_prefix = "cctz-master", )
Since we're not using Bazel, we need to get the dependency ourselves.
Note that they don't pin it to a specific version, they just get it from the latest master at the time of build, so we don't have to worry about getting a specific "compatible" version since they don't do it themselves.
There was a problem hiding this comment.
Ack. Thanks! Still wondering about why we need absl::Mutex though.
There was a problem hiding this comment.
I think this was just inertia on my part, std::mutex should be great too. In which case we can forget about linking with Abseil (and cctz).
4 participants
This is needed by abseil.io, in particular for Mutex. This is step 2 from
https://github.com/abseil/abseil-cpp/blob/master/CMake/README.md