Skip to content

cleanup(GCS+gRPC): simplify support for resumable uploads#7290

Merged
coryan merged 1 commit intogoogleapis:mainfrom
coryan:cleanup-storage-simplify-restore-resumable-session-pr4
Sep 8, 2021
Merged

cleanup(GCS+gRPC): simplify support for resumable uploads#7290
coryan merged 1 commit intogoogleapis:mainfrom
coryan:cleanup-storage-simplify-restore-resumable-session-pr4

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Sep 8, 2021

This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2021
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 504ecd4b7572277aaa15f07a42a9817850cd229b

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 8, 2021

Codecov Report

Merging #7290 (504ecd4) into main (8c6ff70) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7290   +/-   ##
=======================================
  Coverage   93.79%   93.79%           
=======================================
  Files        1339     1339           
  Lines      115480   115460   -20     
=======================================
- Hits       108309   108291   -18     
+ Misses       7171     7169    -2     
Impacted Files Coverage Δ
google/cloud/storage/internal/grpc_client.cc 92.10% <100.00%> (ø)
...loud/storage/internal/grpc_client_failures_test.cc 100.00% <100.00%> (ø)
...age/internal/grpc_resumable_upload_session_test.cc 99.54% <100.00%> (ø)
...rage/internal/grpc_resumable_upload_session_url.cc 100.00% <100.00%> (ø)
...internal/grpc_resumable_upload_session_url_test.cc 100.00% <100.00%> (ø)
google/cloud/completion_queue_test.cc 96.95% <0.00%> (-0.20%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.87% <0.00%> (+0.50%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.51% <0.00%> (+2.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c6ff70...504ecd4. Read the comment docs.

@coryan coryan marked this pull request as ready for review September 8, 2021 14:58
@coryan coryan requested a review from a team September 8, 2021 14:58
@coryan coryan merged commit 0c6ccc8 into googleapis:main Sep 8, 2021
@coryan coryan deleted the cleanup-storage-simplify-restore-resumable-session-pr4 branch September 8, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants