refactor(storage): reduce indirection on restoring uploads#7283
Merged
coryan merged 2 commits intogoogleapis:mainfrom Sep 8, 2021
Merged
Conversation
The `RawClient::RestoreResumableUpload()` function is not really used, and it lacks a parameter with the original request (which may have set options, such as custom headers). With this cleanup the function is deprecated. This enables a change to fully support standard parameters when restoring resumable uploads.
product-auto-label
Bot
added
the
api: storage
googlebot
added
the
cla: yes
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7283 +/- ##
==========================================
+ Coverage 94.33% 94.34% +0.01%
==========================================
Files 1317 1318 +1
Lines 114796 114798 +2
==========================================
+ Hits 108293 108310 +17
+ Misses 6503 6488 -15
Continue to review full report at Codecov.
|
devbww
approved these changes
Sep 8, 2021
| auto session = absl::make_unique<CurlResumableUploadSession>( | ||
| shared_from_this(), request, session_id); | ||
| auto response = session->ResetSession(); | ||
| if (response.status().ok()) { |
Contributor
There was a problem hiding this comment.
Nit: Do we prefer to say this over just if (response)?
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
coryan
deleted the
refactor-storage-simplify-restore-resumable-session-pr2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RawClient::RestoreResumableUpload()function is not really used,and it lacks a parameter with the original request (which may have set
options, such as custom headers). With this cleanup the function is
deprecated. This enables a change to fully support standard parameters
when restoring resumable uploads.
This change is