refactor(storage): simplify internal::CurlClient#7281
Merged
coryan merged 1 commit intogoogleapis:mainfrom Sep 7, 2021
Merged
Conversation
Refactor a template member function that no longer needs to be a template. This will enable further changes related to RestoreResumableSession.
product-auto-label
Bot
added
the
api: storage
googlebot
added
the
cla: yes
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7281 +/- ##
=======================================
Coverage 94.33% 94.34%
=======================================
Files 1317 1317
Lines 114594 114591 -3
=======================================
+ Hits 108107 108109 +2
+ Misses 6487 6482 -5
Continue to review full report at Codecov.
|
devbww
approved these changes
Sep 7, 2021
coryan
deleted the
refactor-storage-simplify-restore-resumable-session-pr1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor a template member function that no longer needs to be a
template. This will enable further changes related to
RestoreResumableSession.
This is motivated by the comments in #7272, so let's call it part of the work for #6982
This change is