feat(storage)!: move GCS+gRPC to v2/ protos#7254
Merged
coryan merged 4 commits intogoogleapis:mainfrom Sep 2, 2021
Merged
Conversation
GCS+gRPC has published a new set of protos to target. These protos rename and change the types for a number of fields, and they *only* describe the RPCs that are actually implemented. The major modifications in this change include: - The type and names of the crc32c and md5_hash fields changed. - Previously the md5 hash was sometimes represented as a hex-encoded binary blob and sometimes as just a binary blob. Now it is always a binary blob. - Several fields (like `if_generation_match` and `crc32c`) are now marked as `optional` in the protos, instead of using `*Value` message wrappers. - The proto version of `ObjectAccessControl` does not contain the `bucket`, `object` or `generation` fields. - Likewise, `BucketAccessControl` does not contain the bucket name. - We use https://github.com/googleapis/storage-testbench as it supports the v2/ protos.
product-auto-label
Bot
added
the
api: storage
google-cla
Bot
added
the
cla: yes
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7254 +/- ##
==========================================
- Coverage 94.35% 94.34% -0.02%
==========================================
Files 1317 1317
Lines 114502 114528 +26
==========================================
+ Hits 108044 108048 +4
- Misses 6458 6480 +22
Continue to review full report at Codecov.
|
coryan
changed the title
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
devjgm
approved these changes
Sep 2, 2021
Contributor
devjgm
left a comment
devjgm
left a comment
There was a problem hiding this comment.
Nice to see the emulator code now living in its own repo.
coryan
deleted the
feat-gcs-grpc-move-implementation-to-v2-pr1-no-emulator
branch
dbolduc
pushed a commit
to dbolduc/google-cloud-cpp
that referenced
this pull request
Sep 4, 2021
GCS+gRPC has published a new set of protos to target. These protos rename and change the types for a number of fields, and they *only* describe the RPCs that are actually implemented. The major modifications in this change include: - The type and names of the crc32c and md5_hash fields changed. - Previously the md5 hash was sometimes represented as a hex-encoded binary blob and sometimes as just a binary blob. Now it is always a binary blob. - Several fields (like `if_generation_match` and `crc32c`) are now marked as `optional` in the protos, instead of using `*Value` message wrappers. - The proto version of `ObjectAccessControl` does not contain the `bucket`, `object` or `generation` fields. - Likewise, `BucketAccessControl` does not contain the bucket name. - We use https://github.com/googleapis/storage-testbench as it supports the v2/ protos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCS+gRPC has published a new set of protos to target. These protos
rename and change the types for a number of fields, and they only
describe the RPCs that are actually implemented.
The major modifications in this change include:
binary blob and sometimes as just a binary blob. Now it is always
a binary blob.
if_generation_matchandcrc32c) are nowmarked as
optionalin the protos, instead of using*Valuemessage wrappers.
ObjectAccessControldoes not contain thebucket,objectorgenerationfields.BucketAccessControldoes not contain the bucket name.supports the v2/ protos.
Part of the work for #6982 Fixes #6643 Fixes #6641
This change is