Skip to content

cleanup(bigtable): don't test time output, which could change#7250

Merged
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:cleanup-bigtable-bench-test
Sep 1, 2021
Merged

cleanup(bigtable): don't test time output, which could change#7250
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:cleanup-bigtable-bench-test

Conversation

@dbolduc
Copy link
Copy Markdown
Member

@dbolduc dbolduc commented Sep 1, 2021 •
edited by coryan
Loading

The time could advance, changing the output by the time we initialize it. The check was unnecessary.

This change is Reviewable

@dbolduc dbolduc requested a review from a team September 1, 2021 19:54
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Sep 1, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 1, 2021
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

google-cloud-cpp-bot commented Sep 1, 2021

Google Cloud Build Logs
For commit: 01f4aeebc12ad165313fccf20de93792b8b4707d

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

scotthart
scotthart approved these changes Sep 1, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dbolduc)

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 1, 2021 •
edited
Loading

Codecov Report

Merging #7250 (01f4aee) into main (890a3ef) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7250      +/-   ##
==========================================
- Coverage   94.36%   94.35%   -0.02%     
==========================================
  Files        1317     1317              
  Lines      114503   114501       -2     
==========================================
- Hits       108051   108035      -16     
- Misses       6452     6466      +14
Impacted Files Coverage Δ
...loud/bigtable/benchmarks/benchmark_options_test.cc 100.00% <ø> (ø)
google/cloud/grpc_error_delegate.cc 95.83% <0.00%> (-4.17%) ⬇️
...bigtable/examples/bigtable_hello_instance_admin.cc 81.31% <0.00%> (-2.20%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 88.10% <0.00%> (-1.49%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 85.52% <0.00%> (-0.66%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.37% <0.00%> (-0.51%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.78% <0.00%> (-0.25%) ⬇️
google/cloud/pubsub/samples/samples.cc 91.75% <0.00%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890a3ef...01f4aee. Read the comment docs.

@dbolduc dbolduc merged commit cea5594 into googleapis:main Sep 1, 2021
@dbolduc dbolduc deleted the cleanup-bigtable-bench-test branch September 1, 2021 20:22
dbolduc added a commit to dbolduc/google-cloud-cpp that referenced this pull request Sep 4, 2021
@dbolduc
cleanup(bigtable): don't test time output, which could change (google…
687b6c9 
…apis#7250)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scotthart scotthart scotthart approved these changes

+1 more reviewer

@devjgm devjgm devjgm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dbolduc @google-cloud-cpp-bot @devjgm @scotthart