Skip to content

chore(release): update changelog for 2021-09 release#7245

Merged
dbolduc merged 2 commits intogoogleapis:mainfrom
dbolduc:update-changelog
Sep 1, 2021
Merged

chore(release): update changelog for 2021-09 release#7245
dbolduc merged 2 commits intogoogleapis:mainfrom
dbolduc:update-changelog

Conversation

@dbolduc
Copy link
Copy Markdown
Member

@dbolduc dbolduc commented Sep 1, 2021 •
edited by coryan
Loading

This change is Reviewable

@dbolduc dbolduc requested a review from a team September 1, 2021 15:40
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 1, 2021
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

google-cloud-cpp-bot commented Sep 1, 2021

Google Cloud Build Logs
For commit: e243cd74362b9d77e3d64d09a6019f5fda56b4f5

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

devbww
devbww reviewed Sep 1, 2021
View reviewed changes
Comment thread CHANGELOG.md Outdated
* feat(common): add GrpcChannelArgumentsNativeOption ([#7194](https://github.com/googleapis/google-cloud-cpp/pull/7194))
* feat(common): capture thread that creates log record ([#7119](https://github.com/googleapis/google-cloud-cpp/pull/7119))


Copy link
Copy Markdown
Contributor

@devbww devbww Sep 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitty nit: Delete extra blank line.

Copy link
Copy Markdown
Member Author

@dbolduc dbolduc Sep 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 1, 2021 •
edited
Loading

Codecov Report

Merging #7245 (ee7291b) into main (be1513b) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7245      +/-   ##
==========================================
- Coverage   94.35%   94.35%   -0.01%     
==========================================
  Files        1317     1317              
  Lines      114503   114503              
==========================================
- Hits       108040   108037       -3     
- Misses       6463     6466       +3
Impacted Files Coverage Δ
...le/cloud/storage/internal/curl_download_request.cc 88.10% <0.00%> (-1.12%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.37% <0.00%> (-0.51%) ⬇️
google/cloud/pubsub/samples/samples.cc 91.75% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be1513b...ee7291b. Read the comment docs.

coryan
coryan approved these changes Sep 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit.

Comment thread CHANGELOG.md Outdated
* feat(storage): add additional examples ([#7224](https://github.com/googleapis/google-cloud-cpp/pull/7224))
* feat(storage): aggregate upload benchmark ([#7190](https://github.com/googleapis/google-cloud-cpp/pull/7190))
* fix(GCS+gRPC): quickstart build with Bazel+Windows ([#7147](https://github.com/googleapis/google-cloud-cpp/pull/7147))
* refactor(storage): isolate header parsing to REST ([#7137](https://github.com/googleapis/google-cloud-cpp/pull/7137))
Copy link
Copy Markdown
Contributor

@coryan coryan Sep 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically we do not include refactor information in the CHANGELOG.

Copy link
Copy Markdown
Contributor

@devjgm devjgm Sep 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could update

google-cloud-cpp/release/changes.sh

Line 51 in be1513b

if grep -qP "^(ci|chore|test|testing|cleanup)\b" <<<"${message}"; then
to exclude refactor by default.

Copy link
Copy Markdown
Member Author

@dbolduc dbolduc Sep 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed others, but wasn't sure about this one. I will remove it.

@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

google-cloud-cpp-bot commented Sep 1, 2021

Google Cloud Build Logs
For commit: ee7291b2b2cc201fa725b9ffb2a37609ab3e88c4

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@dbolduc dbolduc merged commit 890a3ef into googleapis:main Sep 1, 2021
@dbolduc dbolduc deleted the update-changelog branch September 1, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coryan coryan coryan approved these changes

+2 more reviewers

@devbww devbww devbww left review comments

@devjgm devjgm devjgm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dbolduc @google-cloud-cpp-bot @coryan @devjgm @devbww @googlebot