Skip to content

fix: release CurlRequest handles on error#7244

Merged
coryan merged 1 commit intogoogleapis:mainfrom
coryan:fix-cleanup-request-handles-on-error
Sep 1, 2021
Merged

fix: release CurlRequest handles on error#7244
coryan merged 1 commit intogoogleapis:mainfrom
coryan:fix-cleanup-request-handles-on-error

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Aug 31, 2021

This change is Reviewable

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 31, 2021
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: a95ddf0ac2b2e0be2c9867a34617be45ffd9e452

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 31, 2021

Codecov Report

Merging #7244 (a95ddf0) into main (f486e0f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7244   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files        1317     1317           
  Lines      114478   114503   +25     
=======================================
+ Hits       108014   108041   +27     
+ Misses       6464     6462    -2     
Impacted Files Coverage Δ
google/cloud/storage/internal/curl_request.h 100.00% <ø> (ø)
...ge/tests/curl_download_request_integration_test.cc 95.63% <ø> (ø)
google/cloud/storage/internal/curl_request.cc 100.00% <100.00%> (ø)
...oud/storage/tests/curl_request_integration_test.cc 97.06% <100.00%> (+0.15%) ⬆️
google/cloud/bigtable/internal/common_client.h 94.02% <0.00%> (-5.98%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 89.21% <0.00%> (+1.11%) ⬆️
google/cloud/bigtable/internal/common_client.cc 97.14% <0.00%> (+1.42%) ⬆️
google/cloud/grpc_error_delegate.cc 100.00% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f486e0f...a95ddf0. Read the comment docs.

@coryan coryan marked this pull request as ready for review August 31, 2021 23:36
@coryan coryan requested a review from a team August 31, 2021 23:36
@coryan coryan merged commit be1513b into googleapis:main Sep 1, 2021
@coryan coryan deleted the fix-cleanup-request-handles-on-error branch September 1, 2021 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants