Skip to content

cleanup: remove storage/v2 generated files#7243

Merged
coryan merged 2 commits intogoogleapis:mainfrom
coryan:cleanup-remove-storage-v2-protos
Aug 31, 2021
Merged

cleanup: remove storage/v2 generated files#7243
coryan merged 2 commits intogoogleapis:mainfrom
coryan:cleanup-remove-storage-v2-protos

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Aug 31, 2021

I thought we would implement the storage testbench for storage/v2 in
this repository first. But it did not work that way. The testbench is
being actively developed in its own repo. I hope to submit a PR to
switch to that repository in the next few days.


This change is Reviewable

I thought we would implement the storage testbench for storage/v2 in
this repository first. But it did not work that way. The testbench is
being actively developed in [its own repo]. I hope to submit a PR to
switch to that repository in the next few days.

[its own repo]: https://github.com/googleapis/storage-testbench
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 31, 2021
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 7bab531af0cc1760521f4c775dee2fe8ae504083

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 31, 2021

Codecov Report

Merging #7243 (3519c3f) into main (4000299) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7243      +/-   ##
==========================================
- Coverage   94.35%   94.35%   -0.01%     
==========================================
  Files        1317     1317              
  Lines      114478   114478              
==========================================
- Hits       108019   108016       -3     
- Misses       6459     6462       +3     
Impacted Files Coverage Δ
...bigtable/examples/bigtable_hello_instance_admin.cc 81.31% <0.00%> (-2.20%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.37% <0.00%> (-0.51%) ⬇️
google/cloud/pubsub/samples/samples.cc 91.67% <0.00%> (-0.08%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 97.60% <0.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4000299...3519c3f. Read the comment docs.

@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 3519c3fb8472ddd47d9fad8291657ef3dc2065e9

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review August 31, 2021 20:34
@coryan coryan requested a review from a team August 31, 2021 20:34
Copy link
Copy Markdown
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

@coryan coryan merged commit f486e0f into googleapis:main Aug 31, 2021
@coryan coryan deleted the cleanup-remove-storage-v2-protos branch August 31, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants