Skip to content

test(bigtable): add Options constructor for mock clients#7232

Merged
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:bigtable-options-for-mock-clients
Aug 27, 2021
Merged

test(bigtable): add Options constructor for mock clients#7232
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:bigtable-options-for-mock-clients

Conversation

@dbolduc
Copy link
Copy Markdown
Member

@dbolduc dbolduc commented Aug 27, 2021

Part of the work for #6307


This change is Reviewable

@dbolduc dbolduc requested a review from a team August 27, 2021 16:05
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2021
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Aug 27, 2021
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 6a10fe699b7efe1050c1245ffb2a4b341d96ce54

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 27, 2021

Codecov Report

Merging #7232 (6a10fe6) into main (b711471) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7232      +/-   ##
==========================================
- Coverage   93.79%   93.79%   -0.01%     
==========================================
  Files        1338     1338              
  Lines      115145   115148       +3     
==========================================
+ Hits       108000   108002       +2     
- Misses       7145     7146       +1     
Impacted Files Coverage Δ
google/cloud/bigtable/testing/mock_admin_client.h 63.63% <100.00%> (+0.84%) ⬆️
google/cloud/bigtable/testing/mock_data_client.h 79.16% <100.00%> (+0.90%) ⬆️
...loud/bigtable/testing/mock_instance_admin_client.h 69.56% <100.00%> (+0.67%) ⬆️
google/cloud/grpc_error_delegate.cc 95.83% <0.00%> (-4.17%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 89.59% <0.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b711471...6a10fe6. Read the comment docs.

@dbolduc dbolduc merged commit d8bc8ce into googleapis:main Aug 27, 2021
@dbolduc dbolduc deleted the bigtable-options-for-mock-clients branch August 27, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants