feat(bigtable): add Make(Data,Admin,InstanceAdmin)Client methods that take Options#7226
Conversation
googlebot
added
the
cla: yes
product-auto-label
Bot
added
the
api: bigtable
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7226 +/- ##
========================================
Coverage 93.80% 93.81%
========================================
Files 1338 1338
Lines 114948 115118 +170
========================================
+ Hits 107830 107994 +164
- Misses 7118 7124 +6
Continue to review full report at Codecov.
|
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
Some thoughts below, let me know what you think.
| std::move(connection_pool_name_); | ||
| } | ||
| return std::move(opts_); | ||
| }; |
| BackgroundThreadsFactory background_threads_factory() const; | ||
|
|
||
| /// Consume this object and convert it to `Options`. | ||
| Options&& ToOptions() && { |
There was a problem hiding this comment.
Is this something you want in the public API (and therefore maintain forever?) Consider adding a friend function in the internal namespace so it is not a public function.
There was a problem hiding this comment.
Yeah, there was no reason to introduce a public function here.
| /** | ||
| * Create a new data client configured via @p options. | ||
| * | ||
| * @deprecated use the `MakeDataClient` method which accepts |
There was a problem hiding this comment.
Do you have a issue to remind us that this should be labeled with a GOOGLE_CLOUD_CPP_DEPRECATED macro?
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
4 participants
Part of the work for #6307 (nearly there!)
This change
ClientOptions->Optionsfor backwards compatibility:Make*Client(... , Options)methods to replaceCreateDefault*Client(... , ClientOptions)methods.internal::CommonClientimplementation to useOptionsinstead ofClientOptionsStill TODO on #6307, which I will address in subsequent PR's:
Optionsconstructor totesting::Mock*ClientClientOptionsfromtesting::InProcess*ClientCreateDefault*Clientin our examples/tests to useMake*ClientinsteadThis change is