feat(spanner): add generated admin APIs#7183
Merged
devbww merged 1 commit intogoogleapis:mainfrom Aug 17, 2021
Merged
Conversation
Configure generation of the Spanner database/instance admin APIs: - in `google::cloud::spanner_admin` namespace - in `google/cloud/spanner/admin` include path This will allow them to co-exist with the hand-wrought APIs until the latter can be deprecated and eventually removed. The actual merge of the generated code will be in followup PRs.
googlebot
added
the
cla: yes
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
coryan
approved these changes
Aug 17, 2021
Contributor
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @devbww)
Codecov Report
@@ Coverage Diff @@
## main #7183 +/- ##
=======================================
Coverage 94.44% 94.44%
=======================================
Files 1310 1310
Lines 113526 113526
=======================================
+ Hits 107219 107223 +4
+ Misses 6307 6303 -4
Continue to review full report at Codecov.
|
devbww
added a commit
to devbww/google-cloud-cpp
that referenced
this pull request
Aug 31, 2021
Revert googleapis#7183, googleapis#7184, and googleapis#7188 prior to the monthly release, as they implement a partially-complete but user-visible feature. This will avoid any confusion about the availability of the feature.
devbww
added a commit
that referenced
this pull request
Aug 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configure generation of the Spanner database/instance admin APIs:
google::cloud::spanner_adminnamespacegoogle/cloud/spanner/admininclude pathThis will allow them to co-exist with the hand-wrought APIs until
the latter can be deprecated and eventually removed.
The actual merge of the generated code will be in followup PRs.
This change is