ci: parallelize docker RUN builds whenver possible#7060
ci: parallelize docker RUN builds whenver possible#7060devjgm merged 2 commits intogoogleapis:mainfrom
Conversation
googlebot
added
the
cla: yes
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7060 +/- ##
==========================================
- Coverage 94.49% 94.48% -0.02%
==========================================
Files 1304 1304
Lines 112327 112327
==========================================
- Hits 106147 106134 -13
- Misses 6180 6193 +13
Continue to review full report at Codecov.
|
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
Some inconsistencies that you may want to fix.
| -DCRC32C_USE_GLOG=OFF \ | ||
| -H. -Bcmake-out -GNinja && \ | ||
| cmake --build cmake-out --target install && \ | ||
| cmake --build cmake-out --target install -- -j ${NCPU:-4} && \ |
There was a problem hiding this comment.
I thought you wanted "${NCPU}" in non-demo files?
There was a problem hiding this comment.
Oops. Fixed. Re-testing.
| -DCMAKE_CXX_STANDARD=11 \ | ||
| -H. -Bcmake-out -GNinja && \ | ||
| cmake --build cmake-out --target install && \ | ||
| cmake --build cmake-out --target install -- -j ${NCPU:-4} && \ |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
4 participants
I used
${NCPU:-4}(with a default value) in all thedemo-*files. I used${NCPU}in the non-demo files, because its always set in our builds.This change is