doc: fix cmake instructions in top-level README#7057
Merged
coryan merged 1 commit intogoogleapis:mainfrom Jul 26, 2021
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
|
Thanks for the pull request. Do you mind also the file that generates this README? The CI builds will not pass until that is fixed. If this is too annoying we would be happy to make the changes ourselves. |
Reordered command line options, "-C" option is part of the git's general options.
VPeruS
force-pushed
the
readme-correct-cmake
branch
from
657ea82 to
4ff595b
Compare
Contributor
Author
|
Updated bash script. |
Contributor
|
/gcbrun |
kokoro-team
removed
the
kokoro:run
coryan
changed the title
coryan
changed the title
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7057 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 1304 1304
Lines 112319 112319
=======================================
+ Hits 106124 106126 +2
+ Misses 6195 6193 -2
Continue to review full report at Codecov.
|
coryan
approved these changes
Jul 26, 2021
Contributor
|
Thanks again for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reordered command line options, "-C" option is part of the git's general options.
This change is