Skip to content

chore(storage): commit generated proto files#7046

Merged
coryan merged 1 commit intogoogleapis:mainfrom
coryan:feat-gcs-grpc-move-implementation-to-v2-pr0
Jul 23, 2021
Merged

chore(storage): commit generated proto files#7046
coryan merged 1 commit intogoogleapis:mainfrom
coryan:feat-gcs-grpc-move-implementation-to-v2-pr0

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Jul 23, 2021

Instructions on how to generate the python files for the storage protos.
And then generate and commit said protos.

Part of the work for #6982


This change is Reviewable

Instructions on how to generate the python files for the storage protos.
And then generate and commit said protos.
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2021
@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Jul 23, 2021
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 2fcd9ef25cf6c6221ea8af73def9e9d0ebe05ea5

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 23, 2021

Codecov Report

Merging #7046 (2fcd9ef) into main (4f94bc1) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7046      +/-   ##
==========================================
- Coverage   94.48%   94.48%   -0.01%     
==========================================
  Files        1304     1304              
  Lines      112319   112319              
==========================================
- Hits       106125   106124       -1     
- Misses       6194     6195       +1     
Impacted Files Coverage Δ
google/cloud/pubsub/subscriber_connection_test.cc 97.20% <0.00%> (-0.70%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.37% <0.00%> (-0.51%) ⬇️
google/cloud/pubsub/samples/samples.cc 91.67% <0.00%> (-0.08%) ⬇️
google/cloud/grpc_error_delegate.cc 100.00% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f94bc1...2fcd9ef. Read the comment docs.

@coryan coryan marked this pull request as ready for review July 23, 2021 14:24
@coryan coryan requested a review from a team July 23, 2021 14:24
@coryan coryan merged commit e02afad into googleapis:main Jul 23, 2021
@coryan coryan deleted the feat-gcs-grpc-move-implementation-to-v2-pr0 branch July 23, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants