Skip to content

doc(storage): warn customers about changes for mocks#7042

Merged
coryan merged 1 commit intogoogleapis:mainfrom
coryan:doc-storage-warn-users-about-mocking-changes
Jul 22, 2021
Merged

doc(storage): warn customers about changes for mocks#7042
coryan merged 1 commit intogoogleapis:mainfrom
coryan:doc-storage-warn-users-about-mocking-changes

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Jul 22, 2021

This change is Reviewable

@coryan coryan requested a review from a team July 22, 2021 14:07
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2021
@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Jul 22, 2021
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 17e877bf766689a08eb9f4d7613fbe68aac4d3df

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

Copy link
Copy Markdown
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 22, 2021

Codecov Report

Merging #7042 (17e877b) into main (25c957c) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7042      +/-   ##
==========================================
- Coverage   94.48%   94.47%   -0.01%     
==========================================
  Files        1304     1304              
  Lines      112300   112300              
==========================================
- Hits       106103   106100       -3     
- Misses       6197     6200       +3     
Impacted Files Coverage Δ
google/cloud/pubsub/subscriber_connection_test.cc 97.20% <0.00%> (-0.70%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 97.00% <0.00%> (-0.60%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.78% <0.00%> (-0.25%) ⬇️
...sub/internal/batching_publisher_connection_test.cc 97.60% <0.00%> (-0.21%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.87% <0.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25c957c...17e877b. Read the comment docs.

Copy link
Copy Markdown
Contributor

@devbww devbww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@coryan coryan merged commit 942c723 into googleapis:main Jul 22, 2021
@coryan coryan deleted the doc-storage-warn-users-about-mocking-changes branch July 22, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants