Skip to content

cleanup(GCS+gRPC): remove unused functions#7038

Merged
coryan merged 3 commits intogoogleapis:mainfrom
coryan:cleanup-storage-remove-unused-gcs-grpc-functions
Jul 21, 2021
Merged

cleanup(GCS+gRPC): remove unused functions#7038
coryan merged 3 commits intogoogleapis:mainfrom
coryan:cleanup-storage-remove-unused-gcs-grpc-functions

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Jul 21, 2021 •
edited
Loading

Remove functions mapping between REST and gRPC requess, responses, and
metadata. These were only used in tests after the last cleanup.

Part of the work for #6982

This change is Reviewable

@coryan
cleanup(GCS+gRPC): remove unused functions
4250a0e 
Remove functions mapping between REST and gRPC requess, responses, and
metadata. These were only used in tests after the last cleanup.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 21, 2021
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

google-cloud-cpp-bot commented Jul 21, 2021

Google Cloud Build Logs
For commit: 4250a0e1d92e7bcb681f035ac8b3f586dfb4f4a5

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 21, 2021 •
edited
Loading

Codecov Report

Merging #7038 (8ef4f75) into main (46c9e78) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #7038     +/-   ##
=========================================
  Coverage   94.47%   94.47%             
=========================================
  Files        1306     1304      -2     
  Lines      113551   112300   -1251     
=========================================
- Hits       107281   106100   -1181     
+ Misses       6270     6200     -70
Impacted Files Coverage Δ
google/cloud/storage/internal/grpc_client.cc 92.39% <ø> (+2.35%) ⬆️
google/cloud/storage/internal/grpc_client.h 100.00% <ø> (ø)
...torage/internal/grpc_client_object_request_test.cc 100.00% <ø> (ø)
google/cloud/storage/internal/grpc_client_test.cc 100.00% <ø> (ø)
google/cloud/bigtable/async_read_stream_test.cc 97.32% <0.00%> (-0.67%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 97.00% <0.00%> (-0.60%) ⬇️
google/cloud/storage/notification_metadata.h 98.14% <0.00%> (-0.07%) ⬇️
google/cloud/storage/internal/bucket_requests.h 100.00% <0.00%> (ø)
...gle/cloud/storage/internal/notification_requests.h 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46c9e78...8ef4f75. Read the comment docs.

@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

google-cloud-cpp-bot commented Jul 21, 2021

Google Cloud Build Logs
For commit: 452cd4d28db19a7c9f81be93efa11c4e0456c7b6

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review July 21, 2021 20:38
@coryan coryan requested a review from a team July 21, 2021 20:38
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

google-cloud-cpp-bot commented Jul 21, 2021

Google Cloud Build Logs
For commit: 8ef4f752eb334a1af215ebf155326a50750a8bf9

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 30907bc into googleapis:main Jul 21, 2021
@coryan coryan deleted the cleanup-storage-remove-unused-gcs-grpc-functions branch July 21, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@devjgm devjgm devjgm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@coryan @google-cloud-cpp-bot @devjgm @googlebot