cleanup(bigtable): strictly enforce bigtable limits in mutation batcher#7036
Merged
dbolduc merged 2 commits intogoogleapis:mainfrom Jul 21, 2021
Merged
Conversation
product-auto-label
Bot
added
the
api: bigtable
google-cla
Bot
added
the
cla: yes
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7036 +/- ##
==========================================
- Coverage 94.47% 94.47% -0.01%
==========================================
Files 1306 1306
Lines 113541 113551 +10
==========================================
+ Hits 107273 107280 +7
- Misses 6268 6271 +3
Continue to review full report at Codecov.
|
devbww
approved these changes
Jul 21, 2021
| */ | ||
| std::pair<future<void>, future<Status>> AsyncApply(CompletionQueue& cq, | ||
| SingleRowMutation mut); | ||
|
|
Contributor
There was a problem hiding this comment.
I'd probably restore this separating line.
Member
Author
There was a problem hiding this comment.
Whoops. Thanks for catching that
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7030
This change is