Skip to content

doc(storage): fix hashing options documentation#7033

Merged
coryan merged 1 commit intogoogleapis:mainfrom
coryan:doc-storage-fix-hashing-options
Jul 20, 2021
Merged

doc(storage): fix hashing options documentation#7033
coryan merged 1 commit intogoogleapis:mainfrom
coryan:doc-storage-fix-hashing-options

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Jul 20, 2021

Fixes #7027


This change is Reviewable

@coryan coryan requested a review from a team July 20, 2021 16:34
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2021
@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Jul 20, 2021
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 95ec6463523d13a71cf593ea9b7f36b539ed8514

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

Copy link
Copy Markdown
Contributor

@devjgm devjgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 20, 2021

Codecov Report

Merging #7033 (95ec646) into main (a3df9c7) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7033   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files        1305     1305           
  Lines      113350   113350           
=======================================
+ Hits       107082   107084    +2     
+ Misses       6268     6266    -2     
Impacted Files Coverage Δ
google/cloud/storage/hashing_options.h 100.00% <ø> (ø)
...bigtable/examples/bigtable_hello_instance_admin.cc 81.31% <0.00%> (-2.20%) ⬇️
...sub/internal/batching_publisher_connection_test.cc 97.60% <0.00%> (-0.21%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.27% <0.00%> (+0.49%) ⬆️
google/cloud/bigtable/async_read_stream_test.cc 97.99% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3df9c7...95ec646. Read the comment docs.

@coryan coryan merged commit a2d23a6 into googleapis:main Jul 20, 2021
@coryan coryan deleted the doc-storage-fix-hashing-options branch July 20, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DisableCrc32cChecksum doc refers to MD5 hashing

4 participants