feat(GCS+gRPC): upload checksums with last chunk#7031
Merged
coryan merged 2 commits intogoogleapis:mainfrom Jul 20, 2021
Merged
feat(GCS+gRPC): upload checksums with last chunk#7031coryan merged 2 commits intogoogleapis:mainfrom
coryan merged 2 commits intogoogleapis:mainfrom
Conversation
gRPC supports sending the object checksums in the last chunk of a resumable upload. This changes the `internal::ResumableUploadSession` class to receive these checksums, and weaves them through all the decorators and tests. I also changed `internal::ObjectWriteStream` to compute and store the checksums, and only validate them later.
googlebot
added
the
cla: yes
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7031 +/- ##
=======================================
Coverage 94.47% 94.47%
=======================================
Files 1305 1305
Lines 113350 113407 +57
=======================================
+ Hits 107082 107139 +57
Misses 6268 6268
Continue to review full report at Codecov.
|
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gRPC supports sending the object checksums in the last chunk of a
resumable upload. This changes the
internal::ResumableUploadSessionclass to receive these checksums, and weaves them through all the
decorators and tests. I also changed
internal::ObjectWriteStreamtocompute and store the checksums, and only validate them later.
Fixes #4156 and fixes #4157
This change is