test(storage): deflake "plenty clients" tests#7017
Merged
coryan merged 1 commit intogoogleapis:mainfrom Jul 18, 2021
Merged
Conversation
These tests are looking for leaks, but were failing when the number of file descriptors *decreased*, they should only fail if they increased.
product-auto-label
Bot
added
the
api: storage
googlebot
added
the
cla: yes
google-cla
Bot
added
the
cla: yes
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7017 +/- ##
==========================================
- Coverage 94.54% 94.54% -0.01%
==========================================
Files 1305 1305
Lines 114705 114705
==========================================
- Hits 108453 108446 -7
- Misses 6252 6259 +7
Continue to review full report at Codecov.
|
dbolduc
approved these changes
Jul 18, 2021
Member
dbolduc
left a comment
dbolduc
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @coryan)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests are looking for leaks, but were failing when the number of
file descriptors decreased, they should only fail if they increased.
Fixes #7007
This change is