fix(GCS+gRPC): no hashes in Object resource#6963
Merged
coryan merged 2 commits intogoogleapis:mainfrom Jul 9, 2021
Merged
Conversation
The proto file says that neither the `md5_hash` nor the `crc32c` fields should be set when uploading an `Object`: https://github.com/googleapis/googleapis/blob/1eade8161f2ef102282869bc3eb18841807b2b46/google/storage/v1/storage_resources.proto#L691-L694 https://github.com/googleapis/googleapis/blob/1eade8161f2ef102282869bc3eb18841807b2b46/google/storage/v1/storage_resources.proto#L676-L679 Also improved the documentation on how to obtain these hashes for tests.
googlebot
added
the
cla: yes
google-cla
Bot
added
the
cla: yes
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #6963 +/- ##
=======================================
Coverage 94.58% 94.58%
=======================================
Files 1284 1284
Lines 114301 114301
=======================================
+ Hits 108110 108112 +2
+ Misses 6191 6189 -2
Continue to review full report at Codecov.
|
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
scotthart
approved these changes
Jul 9, 2021
Member
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @coryan)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proto file says that neither the
md5_hashnor thecrc32cfieldsshould be set when uploading an
Object:https://github.com/googleapis/googleapis/blob/1eade8161f2ef102282869bc3eb18841807b2b46/google/storage/v1/storage_resources.proto#L691-L694
https://github.com/googleapis/googleapis/blob/1eade8161f2ef102282869bc3eb18841807b2b46/google/storage/v1/storage_resources.proto#L676-L679
Also improved the documentation on how to obtain these hashes for tests.
I disabled some tests that used to pass because the service does not ignore
the hashes in the
Objectresource. The documentation says it does (seethe links), so my tests were passing by accident and the service can change
at any time. Once I fix #4156 and #4157 these tests can be enabled again.
Part of the work for #6946, and will eventually help with #4156 and #4157
This change is