cleanup(storage): error handling in base64 decoding#6961
Merged
coryan merged 1 commit intogoogleapis:mainfrom Jul 10, 2021
Merged
cleanup(storage): error handling in base64 decoding#6961coryan merged 1 commit intogoogleapis:mainfrom
coryan merged 1 commit intogoogleapis:mainfrom
Conversation
google-cla
Bot
added
the
cla: yes
product-auto-label
Bot
added
the
api: storage
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #6961 +/- ##
=======================================
Coverage 94.56% 94.56%
=======================================
Files 1288 1288
Lines 114392 114402 +10
=======================================
+ Hits 108172 108185 +13
+ Misses 6220 6217 -3
Continue to review full report at Codecov.
|
Use StatusOr<> to signal errors when decoding base64 strings. This required changes at the call sites, which I generally handled as follows: - In tests, where the decoding is known to work, I just call `.value()`. - In functions ready to return `StatusOr<>` I just propagate the failure. - In other functions, I changed the chain of calls until all of them had a `Status` or `StatusOr<>`.
coryan
force-pushed
the
cleanup-storage-base64-decode-uses-status-or
branch
from
64d1804 to
a81312f
Compare
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
devbww
approved these changes
Jul 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use StatusOr<> to signal errors when decoding base64 strings. This
required changes at the call sites, which I generally handled as
follows:
.value().StatusOr<>I just propagate thefailure.
a
StatusorStatusOr<>.Fixes #6946
This change is